fix eglDestroySurface argument order (PR #26341)
Florian Larysch
eglDestroySurface takes the display first and the surface second rather than the other way around. Since both EGLDisplay and EGLSurface are just typedef'd to void* this doesn't raise a compiler warning. This currently doesn't crash at runtime because Mesa validates the display pointer against a list of known good values and fails gracefully, but it still causes a resource leak.
I came across this while looking into #26340. This is not the cause, but it still seems worth fixing.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26341
Commit Summary
- 4fb3d93 fix eglDestroySurface argument order
File Changes
(1 file)
- M src/unix/glegl.cpp (2)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26341.patch
- https://github.com/wxWidgets/wxWidgets/pull/26341.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26341)Oops, thanks for finding and fixing this, merged locally and will push soon.
I'm a bit surprised that this is not related to #26340 because 23ccdb2 (Improve and document wxGLCanvas::CreateSurface(), 2023-03-21) which added this call speaks about this code path being taken after reparenting, but I didn't have time to look at the other bug in details yet.
Thanks again for the fix!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.