Move fallback definitions used only in wxWebViewIE to its header (PR #26400)
VZ
Don't define INET_E_XXX symbols use only by wxWebViewIE in wx/msw/missing.h included by all files, this is unnecessary and also can result in problems if the application predefines WIN32_LEAN_AND_MEAN, as these symbols are not defined after including just windows.h in this case but are defined if urlmon.h is included later, e.g. by one of COM headers, as their definitions in urlmon.h would results in redefinition warnings.
Instead, define them only in webview_missing.h and include it after all Windows headers to ensure that these symbols are defined if they are present there (which is probably always the case by now).
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26400
Commit Summary
- f8d4759 Move fallback definitions used only in wxWebViewIE to its header
File Changes
(3 files)
- M include/wx/msw/missing.h (130)
- M include/wx/msw/private/webview_missing.h (127)
- M src/msw/webview_ie.cpp (3)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26400.patch
- https://github.com/wxWidgets/wxWidgets/pull/26400.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.