Add native wxCollapsibleHeaderCtrl implementation for macOS (PR #27058)
Quin Gillespie
As mentioned in #27057, the custom drawn wxCollapsibleHeaderCtrl, used by wxCollapsiblePane and so by the generic about dialog, is invisible to VoiceOver under macOS, so its users can't open the panes or read their contents.
This adds a native implementation for wxOSX, using a borderless toggle button showing a chevron before its label: the native disclosure triangle can't show any label, so it can't be used directly. The button still reports itself as a disclosure triangle to VoiceOver, which then announces its state. Clicking it, Space and the VoiceOver press action all work natively. wxGenericCollapsibleHeaderCtrl remains available under macOS.
Tested with VoiceOver on macOS 26 in the generic about dialog: the headers are read as "License, collapsed, disclosure triangle" etc, can be opened and closed, and the text inside them can be read. The chevron points right when collapsed and down when expanded. I checked the appearance by rendering the dialog into an image, as I can't see the screen; the labels looked a bit dimmed there, probably because that window wasn't active.
One thing I noticed, which might be a more general wxOSX keyboard navigation issue: right after expanding a pane, Tab moves to the next header instead of the text control inside the pane, while Shift-Tab from there goes back to the text control.
build/upmake was run to update the file lists, but I couldn't regenerate Makefile.in or update the Xcode project, as I don't have Bakefile here.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27058
Commit Summary
- de5b5e1 Add native wxCollapsibleHeaderCtrl implementation for macOS
File Changes
(6 files)
- M build/bakefiles/files.bkl (2)
- M build/cmake/files.cmake (2)
- M build/files (2)
- M include/wx/collheaderctrl.h (8)
- A include/wx/osx/collheaderctrl.h (50)
- A src/osx/cocoa/collheaderctrl.mm (73)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27058.patch
- https://github.com/wxWidgets/wxWidgets/pull/27058.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
@trypsynth pushed 1 commit.
- f8f5c9e Add native wxCollapsibleHeaderCtrl to Makefile.in and Xcode project
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Thanks, this looks good to me, but any review/testing (because I don't know if this actually looks correctly) would be very welcome.
@csomor @vslavik Please have a look at this small PR if you can, TIA!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
@trypsynth pushed 2 commits.
- 6a46bad Add native wxCollapsibleHeaderCtrl implementation for macOS
- 6273be8 Add native wxCollapsibleHeaderCtrl to Makefile.in and Xcode project
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.