I need to read external attributes.
The bit that distinguishes a symlink from a regular file is always cleared (reads as regular file)
During the execution of wxZipInputStream::GetNextEntry
the value of m_ExternalAttributes of wxZipEntry is read accurately by wxZipEntry::ReadCentral.
But before it returns,
wxZipEntry::SetName is called (master src/common/zipstrm.cpp:1188)
which calls SetIsDir(false) (master include/wx/zipstrm.h:591)
and it clears the symlink bit.
The external attributes returned by wxZipEntry::GetExternalAttributes
accurately reflect the external attributes stored in the zip file.
When printing the external attributes as hexadecimal,
the first digit is '8' for a regular file, and 'A' for a symlink.
Minimal fix: keep symlink bit.
Enhancement: fully support symlinks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.![]()
I agree that it would make sense to add some IsSymlink() to wxArchiveEntry, any PRs doing this and implementing support for it in wxZipInputStream would be welcome.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.![]()