documentation: add hint for reparenting a notebook page (PR #26292)
Dietmar Schwertberger
This would have saved me an hour...
I could not see, however, where in RemoveTab the page is actually hidden.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26292
Commit Summary
- f6d90db add hint for reparenting a notebook page
File Changes
(1 file)
- M interface/wx/window.h (3)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26292.patch
- https://github.com/wxWidgets/wxWidgets/pull/26292.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Dietmar Schwertberger
@DietmarSchwertberger pushed 1 commit.
- 26e37c0 replace tabs w. spaces
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26292)Sure, this could be applied, but I'm a bit surprised that notebook is mentioned in Reparent() documentation at all. Maybe it would be better to mention in wxNotebook documentation that
- You need to
RemovePage()if you want to reparent the window elsewhere. - And document that
RemovePage()hides it.
?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Dietmar Schwertberger
DietmarSchwertberger left a comment (wxWidgets/wxWidgets#26292)I think the place is the right one. I found the requirement for RemovePage when looking at Reparent. I would not have searched for RemovePage in the beginning. (It would have been fine for me to have an empty page and being able to remove the window back there when the user selects the now empty page.)
Will add the note to RemovePage.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Dietmar Schwertberger
@DietmarSchwertberger pushed 1 commit.
- ad28ac8 add hint also to RemovePage
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Dietmar Schwertberger
DietmarSchwertberger left a comment (wxWidgets/wxWidgets#26292)Yes, the hint could be added to the notebook AddPage documentation.
I would suggest not to do this, though. Reparenting is a niche usage and it would rather confuse newcomers.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Dietmar Schwertberger
@DietmarSchwertberger pushed 1 commit.
- d585fc3 add parens
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.