[3.2] wxQt: fix undefined reference to cairo_surface_get_device_scale() (PR #26220)
Carlo Bramini
This patch fixes issue #26218.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26220
Commit Summary
- 8122265 wxQt: fix undefined reference to cairo_surface_get_device_scale()
File Changes
(1 file)
- M src/common/cairo.cpp (4)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26220.patch
- https://github.com/wxWidgets/wxWidgets/pull/26220.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26220)AFAICS this should be applied to master too, even if this renderer is not used there by default, it can still be used if explicitly chosen, right?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
AliKet
AliKet left a comment (wxWidgets/wxWidgets#26220)AFAICS this should be applied to master too, even if this renderer is not used there by default, it can still be used if explicitly chosen, right?
Yes 👍
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26220)Thanks for the confirmation, I'll apply this to both branches.
BTW, testing compilation here I get
/usr/include/cairo/cairo.h:70:9: warning: "cairo_public" redefined
70 | #define cairo_public _cairo_api extern
| ^~~~~~~~~~~~
src/common/cairo.cpp:19:9: note: this is the location of the previous definition
19 | #define cairo_public
| ^~~~~~~~~~~~
and looking at the header, it looks like we should be predefining CAIRO_WIN32_STATIC_BUILD instead, at least with Cairo 1.18.4 installed here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.