bugfix: wxWebRequestCURL: check for CURL error code when going through completed transfers (PR #26286)
Mongilyov Andrey
Hello!
I have encountered strange bug on Linux when wxWebRequestEvent::GetState() == wxWebRequest::State_Completed, but file is downloaded partially. This reproduces quickly if your internet connection is poor.
In application I now avoid this bug with check for wxWebRequestEvent::GetResponse().GetContentLength() == wxWebRequestEvent::GetRequest().GetBytesReceived(). If file is downloaded partially => condition is not true.
But expected result is wxWebRequestEvent::GetState() == wxWebRequest::State_Failed. Presumably, we need to check for data transfer error in wxWebSessionCURL::CheckForCompletedTransfers().
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26286
Commit Summary
- 7279275 wxWebRequest: check for CURL error code when going through completed transfers
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26286.patch
- https://github.com/wxWidgets/wxWidgets/pull/26286.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26286)Looks good, thanks! I'll apply this soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.