Fix creating empty accelerator table in wxMSW (PR #25538)
VZ
See #25517.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25538
Commit Summary
File Changes
(3 files)
- M interface/wx/accel.h (3)
- M src/msw/accel.cpp (44)
- M tests/menu/accelentry.cpp (14)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25538.patch
- https://github.com/wxWidgets/wxWidgets/pull/25538.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25538)So it turns out that wxMSW was an outlier and that creating wxAccelTable with 0 entries creates a valid (its IsOk() returns true) object in all the other ports. wxMSW behaviour still makes (more) sense to me, so I plan to update all the other ports, but please let me know if anybody disagrees and think it's wxMSW that should be changed (note that while this PR fixes the assert, which is a recent regression, it always created invalid object as ::CreateAcceleratorTable() fails when passed 0 entries).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 4 commits.
- 5a39c3b Simplify code in generic wxAcceleratorTable::Remove()
- b38e7bd Remove unnecessary statement for wxOSX wxAcceleratorTable ctor
- 5fd2f2c Make wxAcceleratorTable with 0 entries invalid in other ports too
- 5d276d8 Make empty wxAcceleratorTable always invalid
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Merged #25538 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.