Add parent distro info to wxLinuxDistributionInfo/wxGetOsDescription (PR #26641)
Blake-Madden
Include the distro name and (Ubuntu) code name (if available/applicable).
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26641
Commit Summary
- fe9bab1 Add parent distro info to wxLinuxDistributionInfo and wxGetOsDescription()
File Changes
(4 files)
- M include/wx/platinfo.h (6)
- M interface/wx/platinfo.h (12)
- M interface/wx/utils.h (1)
- M src/unix/utilsunx.cpp (30)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26641.patch
- https://github.com/wxWidgets/wxWidgets/pull/26641.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Thanks, I never thought this could be useful but why not, I guess.
cc @lanurmi who also worked in this area recently just in case you have any comments
> + *parentName = fc.Read("ID_LIKE", wxEmptyString);
+ *parentCodeName = fc.Read("UBUNTU_CODENAME", wxEmptyString);
Minor, but why do we use wxEmptyString here inconsistently with the lines above? I.e. why not just
- *parentName = fc.Read("ID_LIKE", wxEmptyString);
- *parentCodeName = fc.Read("UBUNTU_CODENAME", wxEmptyString);
+ *parentName = fc.Read("ID_LIKE");
+ *parentCodeName = fc.Read("UBUNTU_CODENAME");
> @@ -131,6 +131,18 @@ struct wxLinuxDistributionInfo
wxString Release; //!< The version of the distribution; e.g. "9.04"
wxString CodeName; //!< The code name of the distribution; e.g. "jaunty"
wxString Description; //!< The description of the distribution; e.g. "Ubuntu 9.04"
+ /**
+ The parent distribution name; e.g. "ubuntu debian".
Is this (and the code name) really in lower case? This looks a bit weird.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- 201ad2c Remove redundant argument
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden commented on this pull request.
> @@ -131,6 +131,18 @@ struct wxLinuxDistributionInfo
wxString Release; //!< The version of the distribution; e.g. "9.04"
wxString CodeName; //!< The code name of the distribution; e.g. "jaunty"
wxString Description; //!< The description of the distribution; e.g. "Ubuntu 9.04"
+ /**
+ The parent distribution name; e.g. "ubuntu debian".
Yes, this is how it appears in my os-release file on Linux Mint. (I thought that looked weird too, I agree.)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.