Fix wxHTML nested definition-list indentation (PR #26676)
Richard Thomson
Track the active DL nesting depth while parsing definition lists and use it when indenting DD content, so nested definition lists are laid out deeper than their parent item. Add parser coverage and a sample case for the old nested DL repro.
Fixes #20752
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26676
Commit Summary
- b845b0b Fix wxHTML nested definition-list indentation
File Changes
(3 files)
- M samples/html/test/test.htm (8)
- M src/html/m_dflist.cpp (20)
- M tests/html/htmlparser.cpp (48)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26676.patch
- https://github.com/wxWidgets/wxWidgets/pull/26676.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
LegalizeAdulthood left a comment (wxWidgets/wxWidgets#26676)failure is due to runner/local-service failure. Port 8081 was already occupied on that Mac ARM ASAN runner, so the webrequest tests pointed at a broken/unusable local httpbin endpoint. It is unrelated to the PR’s nested definition-list indentation changes.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.