Fix wxTextEntryDialog from being resizable to 0, 0 (and other tweaks) (PR #25784)

Blake-Madden

unread,

Sep 9, 2025, 6:38:01 PM (7 days ago) Sep 9

to wx-...@googlegroups.com, Subscribed

I don't see a way to force a max height (only size, which we don't want since the width should always be resizable). However, for a single-line dialog I fixed it so that the button row remains at the bottom of the dialog when resized. That seems much nicer looking then before.
#25739

You can view, comment on, or merge this pull request online at:

https://github.com/wxWidgets/wxWidgets/pull/25784

Commit Summary

f252736 Fix wxTextEntryDialog from being resizable to 0, 0
a9b657b Minor HiDPI fix for wxTextEntryDialog
c6ba75f If wxTextEntryDialog is single-line, then set the button row to remain at the bottom when dialog is resized

File Changes

(1 file)

M src/generic/textdlgg.cpp (11)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Blake-Madden

unread,

Sep 9, 2025, 6:39:11 PM (7 days ago) Sep 9

to wx-...@googlegroups.com, Push

@Blake-Madden pushed 1 commit.

5ba5981 Fix indenting

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

VZ

unread,

Sep 9, 2025, 7:27:29 PM (7 days ago) Sep 9

to wx-...@googlegroups.com, Subscribed

@vadz commented on this pull request.

Thanks, but I hoped using wxTLW::SetMaxSize(wxSize(-1, whatever)) would work, have you tried it and confirmed that it didn't? It would be probably better to make it work, it should be possible, I think...

In src/generic/textdlgg.cpp:

> @@ -81,7 +81,8 @@ bool wxTextEntryDialog::Create(wxWindow *parent,
         return false;
     }
 
-    SetMinSize( sz );
+    if (sz.IsFullySpecified())

Sorry, why do we need this?

In src/generic/textdlgg.cpp:

>          topsizer->Add(buttonSizer, wxSizerFlags().Expand().DoubleBorder());
     }
 
     SetSizer( topsizer );
 
-    topsizer->Fit( this );
+    if (sz.IsFullySpecified())

This also seems suspicious, why should we do this for this particular dialog and not any other ones?