ownerdrw sample broken in wxUniv build in 3.2.12 (Issue #27209)
Wlodzimierz-ABX-Skiba
Wlodzimierz-ABX-Skiba created an issue (wxWidgets/wxWidgets#27209)Build System Used
I build wxWidgets and/or my application using:
- CMake
- configure
- mingw32-make with makefile.gcc
- MSBuild (Microsoft Visual Studio solution file)
- nmake with makefile.vc
- Xcode
Description
In stable branch in samples\ownerdrw\ownerdrw.cpp there is missing #ifndef __WXUNIVERSAL__ around pItem->SetTextColour(*wxRED); (line 218) in sample which is present in master. After adding this #ifndef sample builds fine for 3.2.12. wxW master builds fine for this sample.
Platform and version information
- wxWidgets version you are building: 3.2.12
- wxWidgets port you are building: wxMSWUniv
- OS and its version: Windows 11
- Compiler being used: MinGW-w64
- Non-default compiler options, if any :
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27209)I'll backport your 412125e (Fix samples/ownerdrw sample build with wxUniv, 2025-01-17) to 3.2 too, thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Wlodzimierz-ABX-Skiba
Wlodzimierz-ABX-Skiba left a comment (wxWidgets/wxWidgets#27209)I forgot I did it in 3.3.X myself. Looks like nobody cares for wxUniv anymore. Is it worth to play with it for finding bugs or are there plans to remove it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27209)I admit I don't care about it much myself. Of the ports using it, wxMGL has been already removed, wxDFB will be soon and wxX11 is not really usable. Maybe it could be useful for a future wxWASM port, however...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.