MSW: Dark mode switching for non-rich read-only multiline wxTextCtrl (PR #26629)
Steve Cornett
For dark mode switching, update the background colour for non-rich read-only multiline wxTextCtrl controls. The foreground colour is already updated.
The background colour is controlled by assigning m_backgroundColour rather than calling SetBackgroundColour(). This leaves the m_hasBgCol member untouched so that it distinguishes custom colours set by the user which should not be overwritten, from colours set internally which can be overwritten.
Some checks on the value of hasBgCol are changed to m_backgroundColour.IsOK(). When m_backgroundColour.IsOK() is true, there is either a custom colour or an internally set colour.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26629
Commit Summary
- c0d0a6a Dark mode switching for non-rich read-only multiline wxTextCtrl
File Changes
(3 files)
- M src/msw/control.cpp (2)
- M src/msw/textctrl.cpp (16)
- M src/msw/window.cpp (4)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26629.patch
- https://github.com/wxWidgets/wxWidgets/pull/26629.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Steve Cornett
stevecor left a comment (wxWidgets/wxWidgets#26629)This also fixes the dark mode background of wxMDIClientWindow. This class already sets it's background colour by assigning m_backgroundColour rather than calling SetBackgroundColour().
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz approved this pull request.
Thanks, I've looked at this for a long time but I still can't think of anything that would be broken by this[*], so I'm going to merge it with maybe just a minor comment update.
[*] Which doesn't mean that nothing will — I would actually be surprised if nothing really breaks, but we have to apply this change to see what it is going to be.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.