Build fails with clang and configure in MSYS2 (Issue #23952)
PB
Disclaimer: I am not familiar with configure, this issue was reported on wxForum.
I have installed MSYS2 and two group packages:
mingw-w64-ucrt-x86_64-toolchain (GCC 13.2.0)
mingw-w64-clang-x86_64-toolchain (clang 17.0.1)
I launched clang64.exe from the MSYS2 root folder, in the MSYS2 shell changed to the build folder and successfully ran
../configure --with-msw --disable-dependency-tracking:
Configured wxWidgets 3.3.0 for `x86_64-w64-mingw32'
Which GUI toolkit should wxWidgets use? msw
Should wxWidgets be compiled into single library? no
Should wxWidgets be linked as a shared library? yes
Unicode encoding used by wxString? UTF-16
What level of wxWidgets compatibility should be enabled?
wxWidgets 3.0 no
wxWidgets 3.2 yes
Which libraries should wxWidgets use?
jpeg builtin
png builtin
regex builtin
tiff builtin
lzma no
zlib sys
expat sys
libmspack no
sdl no
I then ran mingw32-make, which resulted in a build error:
g++ -c -o basedll_filename.o -I../3rdparty/pcre/src/wx -ID:/Dev/Desktop/Lib/wxWidgets-PB/build-cl
ang-multi/lib/wx/include/msw-unicode-3.3 -I../include -D_FILE_OFFSET_BITS=64 -D__WXMSW__ -DWXB
UILDING -DwxUSE_GUI=0 -DWXMAKINGDLL_BASE -DwxUSE_BASE=1 -Wall -Wundef -Wunused-parameter -Wno-ctor-
dtor-privacy -Woverloaded-virtual -O2 ../src/common/filename.cpp
In file included from ../src/common/filename.cpp:106:
../include/wx/msw/ole/oleutils.h:107:5: error: 'nodiscard' attribute cannot be applied to types
107 | wxNODISCARD BSTR Get() const { return Copy(); }
| ^
../include/wx/defs.h:273:27: note: expanded from macro 'wxNODISCARD'
273 | #define wxNODISCARD [[nodiscard]]
| ^
1 error generated.
mingw32-make: *** [Makefile:24253: basedll_filename.o] Error 1
wxNODISCARD is a feature present only in 3.3, added in f1985c6.
I noticed that error is in the only wxBasicString method that uses not only wxNODISCARD but also wxDEPRECATED_MSG:
https://github.com/wxWidgets/wxWidgets/blob/4235a018be3c42245f821959d0ee38bb67f43886/include/wx/msw/ole/oleutils.h#L106-L107
After commenting out the wxDEPRECATED_MSG line above and rerunning make, the build finished successfully.
wxWidgets own CMake-based clang MSYS2 CI succeeds: https://github.com/wxWidgets/wxWidgets/actions/runs/6442401188/job/17493193039 (and also does not have countless warnings the configure has?).
The issue is not present when building with GCC in MSYS2 (using the UCRT MSYS2 environment), so I am not sure if the problem is in wxWidgets or (more likely?) the toolchain.
Platform and version information
- wxWidgets version: current GIT master
- wxWidgets port: wxMSW
- OS: Windows 10
- Compiler:
clang version 17.0.1
Target: x86_64-w64-windows-gnu
Thread model: posix
InstalledDir: C:/msys64/clang64/bin
The original report is over a month old, so I think it happened also with clang 16; according to the original reporter, the issue manifests also with clang aarch64.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
PB
Oops, I have only noticed that there is "g++" in the build error, so perhaps I somehow mixed the compilers?
config.log has this (rather confusing for me, who is not familiar with the environment / aliasing):
configure:14526: checking for g++
configure:14542: found /clang64/bin/g++
configure:14553: result: g++
configure:14580: checking for C++ compiler version
configure:14589: g++ --version >&5
clang version 17.0.1
Target: x86_64-w64-windows-gnu
Thread model: posix
InstalledDir: C:/msys64/clang64/bin
configure:14600: $? = 0
configure:14589: g++ -v >&5
clang version 17.0.1
Target: x86_64-w64-windows-gnu
Thread model: posix
InstalledDir: C:/msys64/clang64/bin
The confusion may apply to #23951 as well.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
I'm afraid that exchanging the macros is not going to work for both MSVC and gcc/clang neither, so fixing this is not really trivial. But then I think we should just remove wxNODISCARD from Get(), using this function already results in a warning and giving two of them is probably not very useful.
As for why it doesn't happen with the CI builds, my guess would be that they don't use C++17?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
PB
I'm afraid that exchanging the macros is not going to work for both MSVC and gcc/clang neither
But it works with MSVC and GCC?
But then I think we should just remove
wxNODISCARDfromGet()
Will do.
As for why it doesn't happen with the CI builds, my guess would be that they don't use C++17?
Ah, yes, sorry for not realizing this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #23952 as completed via b87a7ab.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.