Fix static box bgcolor when on wxPanel (MSW dark mode) (PR #24663)
Blake-Madden
Under MSW dark mode, wxStaticBox will have a dark gray background when placed on a wxPanel. It seems that this is the color it is pulling from the parent wxPanel. Explicitly setting the panel's background color to the proper color under dark mode fixes it.
At first I thought of changing wxStaticBox to not use the parent's bgcolor, but perhaps this is a better approach in case their are other controls that also look at the parent's bgcolor. Fixing at the wxPanel level will fix all any of those.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/24663
Commit Summary
- 847df27 Fix static box bgcolor when on wxPanel (MSW dark mode)
File Changes
(1 file)
- M src/common/panelcmn.cpp (12)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/24663.patch
- https://github.com/wxWidgets/wxWidgets/pull/24663.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- ec768fd Fix the same issue in wxDialog
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- 0ac73b4 Fix compiling under MSYS2
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
I think the failures were just timeouts.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.