Update functions.cmake (PR #26338)
Julio Cesar Pérez Franco
Fixed a little error when trying to install "Release" build while the option wxBUILD_INSTALL_PDB is ON.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26338
Commit Summary
- 6f2102b Update functions.cmake
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26338.patch
- https://github.com/wxWidgets/wxWidgets/pull/26338.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26338)Thanks!
@MaartenBent Does this look good to you?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26338)PDB files in Release builds can be useful as well, they give file / line numbers instead of memory addresses.
And they are also available when downloading wxWidgets binaries from the website (even though those are not built with CMake).
Why do you want to disable this?
And if you really need this, I then prefer to make wxBUILD_INSTALL_PDB and 3-way option, OFF, ON, DEBUG_ONLY.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26338)Oops, sorry, I thought the fix was for the problem of not being able to install PDB files because they were not generated in the release build. If they are generated (and I agree that they should be), then I don't understand what does this actually fix.
@juliocesarperezfranco Could you please explain what was the error exactly?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.