Add wxGLContext::GetProcAddress() (PR #26209)
VZ
Implement this function as a trivial wrapper for wglGetProcAddress(), glXGetProcAddressARB() or eglGetProcAddress() depending on the platform (currently not implemented for macOS).
Account for the known bug in some Windows OpenGL drivers by checking for manifestly invalid return values and handling them as null.
Use the new function in wxGL code itself and in the pyramid sample.
Closes #9215.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26209
Commit Summary
- 633ca54 Add wxGLContext::GetProcAddress()
File Changes
(11 files)
- M include/wx/glcanvas.h (16)
- M include/wx/unix/private/glcanvas.h (1)
- M include/wx/unix/private/glegl.h (1)
- M include/wx/unix/private/glx11.h (1)
- M interface/wx/glcanvas.h (65)
- M samples/opengl/pyramid/oglpfuncs.cpp (49)
- M src/msw/glcanvas.cpp (32)
- M src/osx/cocoa/glcanvas.mm (8)
- M src/unix/glcanvas.cpp (6)
- M src/unix/glegl.cpp (29)
- M src/unix/glx11.cpp (31)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26209.patch
- https://github.com/wxWidgets/wxWidgets/pull/26209.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26209)@dsa-t I've finally done the simplest thing possible and just mentioned the Windows complications in the documentation because I'm not sure we should impose the extra burden of selecting the context first on all library users.
Please let me know if this minimal version is sufficient for your needs and, if not, what is missing. TIA!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
dsa-t
dsa-t left a comment (wxWidgets/wxWidgets#26209)Thanks, looks good for me!
On macOS, GLEW and libepoxy load "/System/Library/Frameworks/OpenGL.framework/Versions/Current/OpenGL"
GLAD tries to load from:
static const char *NAMES[] = {
"../Frameworks/OpenGL.framework/OpenGL",
"/Library/Frameworks/OpenGL.framework/OpenGL",
"/System/Library/Frameworks/OpenGL.framework/OpenGL",
"/System/Library/Frameworks/OpenGL.framework/Versions/Current/OpenGL"
};
According to https://yairchu.github.io/posts/intercept-to-fix, "/System/Library/Frameworks/OpenGL.framework/OpenGL" is gone in macOS 11.0
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- 8c10467 Add wxGLContext::GetProcAddress()
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26209)I still have /System/Library/Frameworks/OpenGL.framework/OpenGL (weirdly enough, it's a symlink pointing at non existing Versions/Current/OpenGL, but this doesn't prevent dlopen() from opening it) on my macOS 14.4.1 system, so we could probably use this. But I'm not sure if it's worth doing this without knowing if it actually works or not (although I checked that glGenBuffers I randomly used for my example can be loaded from it). It might, but I really don't like adding code without testing it at all so I'm tempted to merge this and then we can add macOS implementation when you or anybody else needs it, which will hopefully also allow us to test that it actually works.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26209)Merged, we can always add macOS support later.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.