OSX: CEF Fixes w/o DnD (PR #26028)
Stefan Csomor
patches for osx from #24520, for making CEF work, see https://github.com/chromiumembedded/cef
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26028
Commit Summary
- 8dfa720 fix CEF renderer process crash
- 6924afe Make wxWebviewWebkit capture hotkeys less eagerly
- 87ad9df Fix wxPopupTransientWindow's mouse event handling
File Changes
(4 files)
- M src/common/popupcmn.cpp (12)
- M src/osx/cocoa/evtloop.mm (2)
- M src/osx/cocoa/utils.mm (2)
- M src/osx/webview_webkit.mm (4)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26028.patch
- https://github.com/wxWidgets/wxWidgets/pull/26028.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- 656df37 remove trailing whitespace
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #26028.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26028)I don't think it's a good idea to mention commits not existing in this repository in the commit messages so I've cherry picked these commits directly instead as f354cb5, 0cc636a and f03d49c7ba85139fb17fd6a1798727e4ae25b8cb (where I've also simplified the code).
Do you think the remaining wxOSX commits (Coremail@dca4ca3 and Coremail@71bf9d8) from there shouldn't be applied or did you just not have time to look at them yet?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26028)@vadz I wanted to do a separate PR with the DnD patches, to make sure we could better trace things in case problems would come up
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26028)@vadz and it would be Coremail@e998db7
as well, that belongs to the DnD changes
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26028)If you think the commits are fine as they are, let me know and I can just cherry pick myself. Or, if you prefer, please do something like this:
$ git fetch https://github.com/Coremail/wxWidgets/ mac-fix-dnd4cef $ git cherry-pick FETCH_HEAD ... make changes, if necessary ... $ git commit --amend
and then create the PR. TIA!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26028)@vadz thanks, I want to check the image providing code for memory leaks and whether it's a good approach when many items are selected
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26028)If you think the commits are fine as they are, let me know and I can just cherry pick myself. Or, if you prefer, please do something like this:
$ git fetch https://github.com/Coremail/wxWidgets/ mac-fix-dnd4cef $ git cherry-pick FETCH_HEAD ... make changes, if necessary ... $ git commit --amendand then create the PR. TIA!
thanks for the instructions :-)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.