Minor fixes for generic wxTreeCtrl on OSX (PR #25885)
RobertRoeb
- When not having focus, the selection rectangle is light grey and then we have to use the standard black pen to draw over the selection rect, not the white pen used over the blue selection rectangle, when the control has the focus
- toggle the tree also with DClick events like the native control and as you would expect anyways
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25885
Commit Summary
- ee71f0d Minor fixes for generic wxTreeCtrl on OSX
File Changes
(1 file)
- M src/generic/treectlg.cpp (9)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25885.patch
- https://github.com/wxWidgets/wxWidgets/pull/25885.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
> @@ -3902,7 +3903,11 @@ void wxGenericTreeCtrl::OnMouse( wxMouseEvent &event )
{
// only toggle the item for a single click, double click on
// the button doesn't do anything (it toggles the item twice)
- if ( event.LeftDown() )
+ // Reply: wxWidgets only sends one LeftDown() event and if you
Thanks, I'm going to merge this but I don't understand the format of this comment, what is this replying to?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Robert Roebling
--
You received this message because you are subscribed to the Google Groups "wx-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wx-dev+un...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/wx-dev/wxWidgets/wxWidgets/pull/25885/review/3342046573%40github.com.
Vadim Zeitlin
RR> It replies to the two lines of comment directly above it which indicate
I don't think it's a good idea to write dialogue in comments... Why not
just correct the existing comment instead? IMO it would be much clearer.
But, and more importantly, should we actually apply this? According to
your other post, it's rather a bug in wxMac itself which should be fixed,
is it not?
Regards,
VZ
VZ
vadz left a comment (wxWidgets/wxWidgets#25885)Taking into account your post about missing wxEVT_LEFT_DOWN events in wxOSX, I take my words back: we probably shouldn't apply this if we can fix that bug instead.
I can still apply the first part if you'd like.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
RobertRoeb
@RobertRoeb pushed 1 commit.
- 9ee3426 Back out double click change, the bug is in wxMac
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
RobertRoeb
RobertRoeb left a comment (wxWidgets/wxWidgets#25885)I can still apply the first part if you'd like.
Exactly, I just removed the rest
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25885)Thanks, I'll merge this soon but FWIW I think this is still wrong, we really shouldn't be hard coding "white" anywhere, as it must not work in dark mode.
The same applies to wxBLACK_PEN used under non-Mac platforms too, of course...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.