OSX add explicit transparency where missing (PR #26092)

Stefan Csomor

unread,

9:27 AM (6 hours ago) 9:27 AM

to wx-...@googlegroups.com, Subscribed

some controls were missing the info, and #26090 does not get traction

You can view, comment on, or merge this pull request online at:

https://github.com/wxWidgets/wxWidgets/pull/26092

Commit Summary

8b48666 add explicit transparency where missing

File Changes

(2 files)

M include/wx/osx/radiobox.h (2)
M include/wx/osx/radiobut.h (2)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

VZ

unread,

9:34 AM (6 hours ago) 9:34 AM

to wx-...@googlegroups.com, Subscribed

@vadz commented on this pull request.

In include/wx/osx/radiobut.h:

> @@ -37,6 +37,8 @@ class WXDLLIMPEXP_CORE wxRadioButton: public wxRadioButtonBase
     virtual void SetValue(bool val) override;
     virtual bool GetValue() const override;
 
+    virtual bool HasTransparentBackground() override { return true; }

I think we should put this in wxRadioButtonBase, hopefully this shouldn't break anything in the other ports.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Stefan Csomor

unread,

9:50 AM (6 hours ago) 9:50 AM

to wx-...@googlegroups.com, Subscribed

@csomor commented on this pull request.

In include/wx/osx/radiobut.h:

> @@ -37,6 +37,8 @@ class WXDLLIMPEXP_CORE wxRadioButton: public wxRadioButtonBase
     virtual void SetValue(bool val) override;
     virtual bool GetValue() const override;
 
+    virtual bool HasTransparentBackground() override { return true; }

I think we should put this in wxRadioButtonBase, hopefully this shouldn't break anything in the other ports.