Add native wxHyperlinkCtrl implementation for macOS (PR #27059)
Quin Gillespie
Like the collapsible header (#27058), wxHyperlinkCtrl is custom drawn under macOS and so invisible to VoiceOver, which is the other part of the generic about dialog that its users couldn't use (see #27057).
There is no native hyperlink control under macOS, so this uses a borderless button showing an underlined label in the link colour, and reports it as a link to VoiceOver. Like the wxGTK and wxMSW native versions, it derives from wxGenericHyperlinkCtrl, which stores the URL and the colours, and it uses the normal and visited colours, but not the hover one. Clicking it, Space and the VoiceOver press action all mark it as visited and send wxEVT_HYPERLINK, opening the URL by default, and the context menu is still connected for wxHL_CONTEXTMENU.
Tested with VoiceOver on macOS 26 in the generic about dialog: the link is read as a link and pressing it opens the URL. I checked the appearance by rendering the dialog into an image, as I can't see the screen, and it looks the same as the generic version.
Tab navigation in this dialog is a bit strange under macOS: the first Tab press after opening the dialog skips the link and the first pane header, which can still be reached using Shift-Tab. I suspect that the keyboard focus is initially already on one of them and this is a general wxOSX keyboard navigation issue rather than a problem with this control.
build/upmake was run to update the file lists, but Makefile.in and the Xcode project are not updated, as I don't have Bakefile here. The file lists will conflict with #27058, as both add files at the same place, but running build/upmake again after merging the other one resolves this.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27059
Commit Summary
- 705b09d Add native wxHyperlinkCtrl implementation for macOS
File Changes
(6 files)
- M build/bakefiles/files.bkl (2)
- M build/cmake/files.cmake (2)
- M build/files (2)
- M include/wx/hyperlink.h (2)
- A include/wx/osx/hyperlink.h (55)
- A src/osx/cocoa/hyperlink.mm (90)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27059.patch
- https://github.com/wxWidgets/wxWidgets/pull/27059.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
@trypsynth pushed 1 commit.
- 9ee9325 Add native wxHyperlinkCtrl to Makefile.in and Xcode project
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Same comment as for the previous PR: looks good to me, but I didn't test it, so if any Mac people could do it, this would be very welcome.
@csomor @vslavik Sorry to keep tagging you, but please have a look at this one too if you can.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Steve Cornett
stevecor left a comment (wxWidgets/wxWidgets#27059)When the mouse moves over the hyperlink, the pointer incorrectly does not change to the hand cursor. It remains the arrow cursor. Tested on macOS 26.6.2.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
@trypsynth pushed 1 commit.
- 34753e1 fix missing hand cursor over native wxHyperlinkCtrl under macOS
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
trypsynth left a comment (wxWidgets/wxWidgets#27059)@stevecor Thanks a lot for testing! I've pushed a fix setting the hand cursor for the control, as the generic version does when the mouse is over the link. wxOSX already sets the window cursor when the mouse enters a native view, so this should be enough, but I can't check it myself as I can't see the screen. Could you please test it again?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Steve Cornett
stevecor left a comment (wxWidgets/wxWidgets#27059)The mouse pointer correctly changes to the hand icon now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
trypsynth left a comment (wxWidgets/wxWidgets#27059)@stevecor Thanks a lot for testing it again!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.