Missing doc updates for updated GetMinimisedIcon(Bundle) methods (PR #26406)

12 views
Skip to first unread message

mcorino

unread,
Apr 24, 2026, 8:19:19 AM (4 days ago) Apr 24
to wx-...@googlegroups.com, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26406

Commit Summary

  • c4f735d Missing doc updates for updated GetMinimisedIcon(Bundle) methods

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26406@github.com>

mcorino

unread,
Apr 24, 2026, 8:20:44 AM (4 days ago) Apr 24
to wx-...@googlegroups.com, Subscribed
mcorino left a comment (wxWidgets/wxWidgets#26406)

@Randalphwa @vadz Another doc miss.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26406/c4313086144@github.com>

VZ

unread,
Apr 24, 2026, 8:39:55 AM (4 days ago) Apr 24
to wx-...@googlegroups.com, Subscribed

@vadz commented on this pull request.


In interface/wx/ribbon/panel.h:

> @@ -190,8 +190,8 @@ class wxRibbonPanel : public wxRibbonControl
         Get the bitmap to be used in place of the panel children when it is
         minimised.
     */
-    wxBitmap& GetMinimisedIcon();
-    const wxBitmap& GetMinimisedIcon() const;
+    wxBitmap GetMinimisedIcon();
+    const wxBitmap& GetMinimisedIconBundle() const;

This should be

⬇️ Suggested change
-    const wxBitmap& GetMinimisedIconBundle() const;
+    const wxBitmapBundle& GetMinimisedIconBundle() const;

I'll merge it with this fix a bit later.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26406/review/4170476363@github.com>

VZ

unread,
Apr 24, 2026, 1:14:37 PM (4 days ago) Apr 24
to wx-...@googlegroups.com, Subscribed

Closed #26406 via 1a8ef74.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26406/issue_event/24846103893@github.com>

Reply all
Reply to author
Forward
0 new messages