wxQt: Fix window modality when using wxWindowDisabler (PR #26134)
AliKet
To see the problem:
- Run the printing sample
- Display the print preview window: File->Print preview... or Ctrl+V
- The window is incorrectly in a disabled state (see the first image below)
and should look like this:
printdemo_good.png (view on web)I'll update the documentation once these changes are approved.
TIA!
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26134
Commit Summary
- 4c0c648 Extend wxWindowDisabler with a constructor to disable the parent window only
- fe55e51 Add wxQt own implementation of wxWindowDisabler::DoDisable() and destructor.
- 5a58d5e wxQt: Fix wxPreviewFrame's window modality using wxWindowDisabler
File Changes
(4 files)
- M include/wx/utils.h (5)
- M src/common/prntbase.cpp (38)
- M src/common/utilscmn.cpp (77)
- M src/qt/window.cpp (69)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26134.patch
- https://github.com/wxWidgets/wxWidgets/pull/26134.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Sorry, I don't particularly like adding another ctor to wxWindowDisabler as this will make it even more confusing to use (and it's already not great) and I also don't understand why do we need to use this class, whose original purpose was to disable all windows, to disable just the parent?
What is the underlying problem in wxQt that this fixes? I.e. why does disabling the parent doesn't work there? Could we work around this at wxWindow level, somehow?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
AliKet
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
AliKet
AliKet left a comment (wxWidgets/wxWidgets#26134)Replaced by #26137
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.