Re: CVS: [JS] wxWindows/src/msw/wince time.cpp,1.13,1.14

0 views

Skip to first unread message

ABX

unread,

Sep 19, 2006, 1:15:56 PM9/19/06

to wx-...@lists.wxwidgets.org

anon...@sunsite.dk:
> Update of /pack/cvsroots/wxwidgets/wxWindows/src/msw/wince
> In directory sunsite.dk:/tmp/cvs-serv13824/src/msw/wince
>
> Modified Files:
> time.cpp
> Log Message:
> Removed rogue continue statement (bug 1560636)

Well, perhaps that contuinue was pointless but have you actually looked into
whole code around it after 'continue' removal? It causes warning:

wince\time.cpp(453) : warning C4701: local variable 'diff' may be used without
having been initialized

and ... when exactly 'diff' has real value assigned?

case 'z':
{
int diff;
char const *sign;

if (t->tm_isdst < 0)
continue;
if (diff < 0)
{
sign = "-";
diff = -diff;
}
else
sign = "+";
pt = _add(sign, pt, ptlim);
diff /= 60;
pt = _conv((diff/60)*100 + diff%60, "%04d", pt, ptlim);
}
continue;