wxAuiToolBar should update packing/padding/margins on DPI change on MSW (Issue #26076)
dsa-t
dsa-t created an issue (wxWidgets/wxWidgets#26076)Description
wxAuiToolBar::Create contains initialization of some packing/padding/margins values which are not updated on DPI change. Would be great to have them updated on DPI change.
Probably needs some flags to detect if user calls SetToolPacking/SetToolBorderPadding/SetMargins to disable these automatic updates.
This only matters on MSW.
Platform and version information
- wxWidgets version you use: master (3.3)
- wxWidgets port you use: wxMSW
- OS and its version: Windows 11
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26076)I think we should do the same thing as we did in 0e7420f (Fix per-monitor DPI handling of wxAuiToolBarArt element sizes, 2025-02-24) and 43b55cf (Avoid scaling small metrics by DPI in wxAuiDockArt, 2025-02-22), i.e. just store these values in DIPs and apply FromDIP() when using them.
The only problem is that SetToolPacking() and SetMargins() would need to use ToDIP() to remain compatible which is a bit weird, but I guess not that much of a problem in practice.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26076)AFAICS this is as simple as #26235, please let me know if you (still) see any problems with it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.