Fix disabled wxListCtrl background colour (PR #26072)

18 views
Skip to first unread message

Maarten

unread,
Jan 5, 2026, 2:37:45 PM (6 days ago) Jan 5
to wx-...@googlegroups.com, Subscribed

Fixes #26068


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26072

Commit Summary

  • 3a26e76 Fix disabled wxListCtrl background colour

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26072@github.com>

VZ

unread,
Jan 5, 2026, 3:01:33 PM (6 days ago) Jan 5
to wx-...@googlegroups.com, Subscribed

@vadz approved this pull request.

Thanks for fixing this, will merge soon (with a possible rename).


In src/msw/listctrl.cpp:

> @@ -3305,6 +3305,16 @@ void DrawGridLines(wxListCtrl* listctrl, int item, int gap = 0)
     }
 }
 
+wxColour GetListCtrlBgCol(wxListCtrl* listctrl)

Maybe rename this to GetEffectiveBackgroundColour() or something like this to make it more clear that this is different from member GetBackgroundColour()?

(I could change this myself when applying if you agree)


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26072/review/3628240362@github.com>

Maarten

unread,
Jan 5, 2026, 3:12:04 PM (6 days ago) Jan 5
to wx-...@googlegroups.com, Subscribed

@MaartenBent commented on this pull request.


In src/msw/listctrl.cpp:

> @@ -3305,6 +3305,16 @@ void DrawGridLines(wxListCtrl* listctrl, int item, int gap = 0)
     }
 }
 
+wxColour GetListCtrlBgCol(wxListCtrl* listctrl)

Fine with me 👍


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26072/review/3628270837@github.com>

VZ

unread,
Jan 8, 2026, 5:05:02 PM (3 days ago) Jan 8
to wx-...@googlegroups.com, Subscribed

Closed #26072 via 8dcb541.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26072/issue_event/21933886343@github.com>

Reply all
Reply to author
Forward
0 new messages