except sample: catch the string type that is actually thrown (PR #26917)
Gunter Königsman
When porting wxWidgets to GTK4 Claude reckons to have found 6 bugs in wxWidgets that hinder samples, example applications or tests from working. To me as a casual outsider the patches look like actually resolving existing bugs. I currently push them as separate pull requests so they can be individually reviewed.
This pull request resolves the issue that trying to issue a string-type exception in the exception sample causes an assert about an unknown string type.
MyFrame::ProcessEvent() catches
catch ( const wxChar *msg )
but the string thrown by the sample is a const char*, so in a build where wxChar is wchar_t the handler never matches and the exception escapes to the outer handler instead of demonstrating what it is there to demonstrate.
Catch const char* and convert explicitly for the log message.
(cherry picked from commit 8511f2f)
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26917
Commit Summary
- 3801b4d except sample: catch the string type that is actually thrown
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26917.patch
- https://github.com/wxWidgets/wxWidgets/pull/26917.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26917)This is definitely right, thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.