Set wxSlider thumb size to match its initial size in wxMSW (PR #26372)
VZ
The changes of 8f3b87d (Fix wxSlider::SetThumbLength() on wxMSW, 2019-01-31) broke the behaviour of wxSlider controls created with a fixed height as their thumb didn't fit it any longer and left no space for ticks at all.
Work around this by setting the initial thumb size ourselves if a fixed control size is given. Also use the fixed default thumb size when calculating the best size as the value of GetThumbLength() could vary depending on how the control was created.
It might be better to revert the use of TBS_FIXEDLENGTH and just leave with the default thumb size in any DPI.
See #1208.
@MaartenBent I had to change this because existing code using fixed sizes for its controls got completely wrecked by this change. This is the minimal fix I can see for it, but as I mentioned above, I'm not sure why we can't leave the control manage its thumb size itself, it looks fine to me in 200% DPI (under Windows 10), do you remember by chance which problem did the original change fix? FWIW I don't think we care about SetThumbLength() one way or the other, nobody uses it anyhow.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26372
Commit Summary
- a8bf862 Set wxSlider thumb size to match its initial size in wxMSW
File Changes
(1 file)
- M src/msw/slider.cpp (46)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26372.patch
- https://github.com/wxWidgets/wxWidgets/pull/26372.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.