Simplify clipboard operations in GTK (PR #26278)
davidedmundson
When changing the clipboard contents the current code emits a lot of noise on the X11 connection, it clears the contents and verifies it's empty before settings the new content.
This non-atomic operation is problematic for desktop environments with clipboard managers that try to replace an empty clipboard. It becomes racey with us setting our new contents.
See #26265
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26278
Commit Summary
- bd0fa0d Simplify clipboard operations in GTK
File Changes
(1 file)
- M src/gtk/clipbrd.cpp (13)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26278.patch
- https://github.com/wxWidgets/wxWidgets/pull/26278.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
davidedmundson
@davidedmundson pushed 1 commit.
- 18261dc Simplify clipboard operations in GTK
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
davidedmundson
@davidedmundson pushed 1 commit.
- 9b65195 Simplify clipboard operations in GTK
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26278)Thanks David! Other than (presumably accidental?) change to submodules, this looks fine to me, so I'll merge this if there are no objections.
And this is probably safe to backport to 3.2 too, at least I can't think of anything this change could break, can anyone else?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
davidedmundson
davidedmundson left a comment (wxWidgets/wxWidgets#26278)And this is probably safe to backport to 3.2 too,
Yeah, I did my main real-world testing for the actual bugfix against 3.2.
I can't see anything that would break.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.