Provide some control over IME (PR #27026)
VZ
Allow enabling/disabling the IME and positioning its window.
This is still WIP but any testing, especially by people actually using IME would be very welcome. I've did some myself using Microsoft Bopomofo and Pinyin under Windows and Fcitx Pinyin under Linux and I could enter "nihao" and "womenhao" (I've tried using input that produces multiple characters) and this seemed to work correctly but I couldn't (and probably won't be able to) test under macOS and I have no idea if the behaviour is not wrong in some non-obvious way.
For example, under Windows I see that the indicator on the taskbar switches to English when focus is on the read-only grid cell and back to Chinese when it goes away from it. Is this expected behaviour? I'm not sure if we can avoid this, but it looks a bit annoying...
Thanks in advance for any testing!
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27026
Commit Summary
- 76e685f Move IMM function wrappers used in wxMSW into a class
- c9d12fc Add wxIMCContext RAII helper wrapping HIMC
- cc43fa9 Add wxWindow::EnableInputMethod() for disabling IME
- a9390a6 Prevent IME from being used for read-only wxGrid cells
- 4a80ac3 Make wxGTK wxScrolled::GetViewStart() behave as the generic version
- 068588b Provide a way to position IME window
File Changes
(13 files)
- M include/wx/generic/grid.h (4)
- M include/wx/generic/private/grid.h (4)
- M include/wx/gtk/window.h (5)
- M include/wx/msw/window.h (1)
- M include/wx/window.h (39)
- M interface/wx/window.h (88)
- M src/common/wincmn.cpp (45)
- M src/generic/grid.cpp (82)
- M src/gtk/scrolwin.cpp (10)
- M src/gtk/window.cpp (57)
- M src/msw/window.cpp (182)
- M src/osx/cocoa/window.mm (30)
- M tests/controls/windowtest.cpp (39)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27026.patch
- https://github.com/wxWidgets/wxWidgets/pull/27026.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 2 commits.
- eb685ad Disable IME when the current wxGrid cell doesn't support text input
- d9b2e44 Disable IME in generic wxDataViewCtrl
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27026)Actually after 2 other minor fixes I don't think there is anything really missing here, so I'd like to merge this.
Of course, it would be best if this could be tested first but, from prior experience, it seems unlikely that anybody is going to do it before it's in master anyhow, so unless someone points out some serious problems with this PR soon, I'll merge it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.