(#16428) allow to set custom font for generic tree ctl (gtk) (PR #25851)

Ivan Baidakou

unread,

Oct 2, 2025, 4:36:47 AMOct 2

to wx-...@googlegroups.com, Subscribed

Hi.

This allows to set custom font the tree component on linux.

Also should fix the issue #16428

You can view, comment on, or merge this pull request online at:

https://github.com/wxWidgets/wxWidgets/pull/25851

Commit Summary

d9d7323 (#16428) allow to set custom font for generic tree ctl (gtk)

File Changes

(1 file)

M src/generic/treectlg.cpp (12)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

VZ

unread,

Oct 2, 2025, 6:08:48 AMOct 2

to wx-...@googlegroups.com, Subscribed

@vadz commented on this pull request.

Thanks, this is probably correct, although the interaction of this check with the check for !m_hasExplicitFont just above is rather confusing.

I do have to wonder why do we need m_normalFont at all instead of just using m_font...

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Ivan Baidakou

unread,

Oct 2, 2025, 6:29:55 AMOct 2

to wx-...@googlegroups.com, Subscribed

basiliscos left a comment (wxWidgets/wxWidgets#25851)

I do have to wonder why do we need m_normalFont at all instead of just using m_font

I have no idea. If you are k, I can remove all usages of m_normalFont (+ probably m_hasExplicitFont)

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

VZ

unread,

Oct 25, 2025, 5:42:16 PM (6 days ago) Oct 25

to wx-...@googlegroups.com, Subscribed

vadz left a comment (wxWidgets/wxWidgets#25851)

Hmm, actually this doesn't fix the problem reported in #16428 for me, after applying it the item height is still not decreased after resetting the font.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

VZ

unread,

Oct 25, 2025, 6:12:08 PM (6 days ago) Oct 25

to wx-...@googlegroups.com, Subscribed

Closed #25851.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

VZ

unread,

Oct 25, 2025, 6:12:09 PM (6 days ago) Oct 25

to wx-...@googlegroups.com, Subscribed

vadz left a comment (wxWidgets/wxWidgets#25851)

Finally, I just don't understand what problem this PR fixes, so I'd rather not apply this. However I made #25927 which fixes a couple of problems, including the original bug and maybe whatever problem you had. Please test that PR and if it doesn't fix your problem, please describe it there. Thanks!