Hi.
This allows to set custom font the tree component on linux.
Also should fix the issue #16428
https://github.com/wxWidgets/wxWidgets/pull/25851
(1 file)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@vadz commented on this pull request.
Thanks, this is probably correct, although the interaction of this check with the check for !m_hasExplicitFont just above is rather confusing.
I do have to wonder why do we need m_normalFont at all instead of just using m_font...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
I do have to wonder why do we need m_normalFont at all instead of just using m_font
I have no idea. If you are k, I can remove all usages of m_normalFont (+ probably m_hasExplicitFont)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Hmm, actually this doesn't fix the problem reported in #16428 for me, after applying it the item height is still not decreased after resetting the font.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Closed #25851.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Finally, I just don't understand what problem this PR fixes, so I'd rather not apply this. However I made #25927 which fixes a couple of problems, including the original bug and maybe whatever problem you had. Please test that PR and if it doesn't fix your problem, please describe it there. Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.