OSX turn off clipping in composite controls (PR #26955)
Stefan Csomor
see discussion in #26952
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26955
Commit Summary
File Changes
(7 files)
- M include/wx/osx/cocoa/private.h (3)
- M include/wx/osx/core/private.h (1)
- M include/wx/osx/textctrl.h (2)
- M include/wx/osx/window.h (1)
- M src/osx/cocoa/window.mm (4)
- M src/osx/textctrl_osx.cpp (10)
- M src/osx/window_osx.cpp (12)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26955.patch
- https://github.com/wxWidgets/wxWidgets/pull/26955.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- d35a4fb whitespace corrections
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz approved this pull request.
Great, thanks, this looks exactly like what I had in mind.
Did you check that this actually fixed #26952?
And, also, can we remove MacClipsToBounds() call added in cc0fd2c (Improve wxSpinCtrl sizing and appearance on macOS, 2025-09-07) now?
> @@ -268,6 +268,16 @@ wxSize wxTextCtrl::DoGetSizeFromTextSize(int xlen, int ylen) const
return size;
}
+void wxTextCtrl::DoSetSize(int x, int y, int width, int height, int sizeFlags)
+{
+ wxTextCtrlBase::DoSetSize(x, y, width, height, sizeFlags);
+ wxWindow* parent = GetParent();
+ if ( parent && parent->MacIsUserPane() && GetPosition().y == 0 ) {
Tiny style nitpick
⬇️ Suggested change- if ( parent && parent->MacIsUserPane() && GetPosition().y == 0 ) {
+ if ( parent && parent->MacIsUserPane() && GetPosition().y == 0 )
+ {
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- 9be5d6e Update src/osx/textctrl_osx.cpp
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26955)Great, thanks, this looks exactly like what I had in mind.
Did you check that this actually fixed #26952?
yes, it does
And, also, can we remove
MacClipsToBounds()call added in cc0fd2c (Improve wxSpinCtrl sizing and appearance on macOS, 2025-09-07) now?
according to my tests, it solves this as well
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.