Fix wrong origin offset when using wxRenderer with wxGCDC (PR #25967)
VZ
ConvertToRECT() in wxRenderer code accounted for the origin shift twice when using wxGCDC since the changes of 4f9186f (Increase usable scrolling range in wxMSW by a factor of 10,000, 2022-04-30) which added Offset(dc.GetDeviceOrigin()) call to it as for wxGCDC this offset is already accounted for by MSWApplyGDIPlusTransform().
Fix this by replacing MSWApplyGDIPlusTransform() with a more generic MSWApplyWXTransform() which does the same thing as before for wxGCDC but applies the origin offset for other wxDCs. This ensures that this offset is properly accounted for in both cases.
Closes #25966.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25967
Commit Summary
- 88f900b Fix wrong origin offset when using wxRenderer with wxGCDC
File Changes
(6 files)
- M include/wx/dc.h (13)
- M include/wx/dcgraph.h (2)
- M include/wx/msw/dc.h (2)
- M src/common/dcgraph.cpp (2)
- M src/msw/dc.cpp (10)
- M src/msw/renderer.cpp (10)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25967.patch
- https://github.com/wxWidgets/wxWidgets/pull/25967.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25967)Merged in the commit above.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #25967.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.