wxTextCtrl border is gone (Issue #26800)

[Dan]

CEXT-Dan created an issue (wxWidgets/wxWidgets#26800)

Description

Platform and version information

• wxWidgets version you use: Latest Build from Master
• wxWidgets port you use: wxMSW
• OS and its version: Windows 11

Testing my application on the latest 3.3.3, I noticed the border for wxTextCtrl is just a line. Is this by design?

Image: Image (view on web)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/26800@github.com>

[BazaarAcc32]

BazaarAcc32 left a comment (wxWidgets/wxWidgets#26800)

If this is by design, I think it needs to be fixed so that the border is fully visible, otherwise the interface will look inconsistent because if you look at the other controls, they have a border on all sides.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/26800/5225657509@github.com>

[Dan]

CEXT-Dan left a comment (wxWidgets/wxWidgets#26800)

I’m using a custom wxDarkModeSettings similar to what is shown in one of the samples, which could be the reason.

class WxArxDarkModeSettings : public wxDarkModeSettings
{
public:
    static COLORREF backgroundColor()
    {
        return RGB(45, 49, 53);
    }

    wxColour GetColour(wxSystemColour index) override
    {
        static wxColour clr = backgroundColor();
        switch (index)
        {
            case wxSYS_COLOUR_APPWORKSPACE:
            case wxSYS_COLOUR_INFOBK:
            case wxSYS_COLOUR_LISTBOX:
            case wxSYS_COLOUR_WINDOW:
            case wxSYS_COLOUR_BTNFACE:
                return clr;
            default:
                return wxDarkModeSettings::GetColour(index);
        }
    }
};

Image: Image (view on web) Image: Image (view on web) Image: Image (view on web)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/26800/5225705003@github.com>

[Dan]

CEXT-Dan left a comment (wxWidgets/wxWidgets#26800)

I see the intent, maybe it’s just bad luck that CAD’s theme color it the same as the border. This is a shot overlaying Paint, thinking maybe there’s a way to set something up from wxDarkModeSettings, maybe honor wxPen GetBorderPen() override in wxTextCtrl, or add something like wxSYS_COLOUR_TEXTCTRLBK

Image: Image (view on web)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/26800/5226349253@github.com>

[VZ]

Closed #26800 as completed via fb7f082.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issue/26800/issue_event/29188510571@github.com>