Various small fixes to wxSVGFileDC (PR #26362)
Blake-Madden
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26362
Commit Summary
- 341b52b Guard against negative pen widths
- b587e33 Fix incorrect size passed to substringing
- 19dd909 Clip rect should use no stroke, not gray
File Changes
(1 file)
- M src/common/dcsvg.cpp (11)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26362.patch
- https://github.com/wxWidgets/wxWidgets/pull/26362.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Thanks, the other commits look good but I'd rather not apply the first one.
> @@ -204,7 +204,7 @@ wxString GetPenStyle(const wxPen& pen)
{
wxString penStyle;
- penStyle += wxString::Format(wxS("stroke-width=\"%d\""), pen.GetWidth());
+ penStyle += wxString::Format(wxS("stroke-width=\"%d\""), wxMax(0, pen.GetWidth()));
Sorry, I don't think this is the right place to do this. Negative pen widths are not allowed, we need to detect this in wxPen::SetWidth() and assert there, not allow silently using them as invisible pens.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- 88fe94f Rollback pen width guard
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden commented on this pull request.
> @@ -204,7 +204,7 @@ wxString GetPenStyle(const wxPen& pen)
{
wxString penStyle;
- penStyle += wxString::Format(wxS("stroke-width=\"%d\""), pen.GetWidth());
+ penStyle += wxString::Format(wxS("stroke-width=\"%d\""), wxMax(0, pen.GetWidth()));
OK, just rolled that one back.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
@Blake-Madden pushed 1 commit.
- e40a1c6 Fix swapped clip ID and nesting level variables in SVG DC
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.