Improve precise wxTreeCtrl best size calculation (PR #25930)
VZ
Try to compute the size of the items manually, even if GetBoundingRect() doesn't return it, as it happens when the items are collapsed.
This ensures the tree control best size is big enough to show the tree fully expanded.
Closes #25839.
Replaces #25843.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25930
Commit Summary
- 593ba84 Improve precise wxTreeCtrl best size calculation
File Changes
(1 file)
- M src/common/treebase.cpp (81)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25930.patch
- https://github.com/wxWidgets/wxWidgets/pull/25930.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
ssrlive
ssrlive left a comment (wxWidgets/wxWidgets#25930)—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25930)Sorry but I'd really appreciate if you could reformulate your comment in a text form because I have no idea what do you mean by this image.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
ssrlive
ssrlive left a comment (wxWidgets/wxWidgets#25930)Here are the results of my tests on three OSs using your PR code. Looks good.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #25930.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25930)Merged in the commit above.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
ssrlive
ssrlive left a comment (wxWidgets/wxWidgets#25930)After I deleted this code, it ran like the picture below. I think it is safe to delete this code.
image.png (view on web)—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25930)After I deleted this code, it ran like the picture below. I think it is safe to delete this code.
When using 200% DPI it looks bad without this extra indent:
image.png (view on web)so I'd rather keep it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.