Add support for minimizing panes to wxAUI (PR #26009)
VZ
See #23986.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26009
Commit Summary
- db07faf Add wxAuiDefaultDockArt::GetPaneButtonBitmap()
- fb23495 Revert "add wxCheckBox to toolbar samples"
- 1bb9635 Simplify wxAuiToolBarItem initialization
- f1e9728 Change initial values of some wxAuiToolBarItem fields
- b4f2321 Simplify tool size calculation code in wxAuiGenericToolBarArt
- ca99399 Check that wxAUI_TB_HORZ_LAYOUT isn't used with wxAUI_TB_VERTICAL
- 9b278b1 Document wxAuiGenericToolBarArt and wxAuiMSWToolBarArt too
- 6b0b8ed Add support for rendering text vertically to wxAuiToolBar
- f084a3e Add wxAUI_TB_VERT_TEXT_{DOWN,UP} styles
- c3e0e79 Add support for drawing "minimized" button in AUI panes
- 7d87a3f Don't forcible reset item min size to (1,1) in wxAUI
- fb1eef0 Use best size normally in wxAuiToolBar
- 023a984 Add initial support for minimized panes to wxAUI
- 9ce02a8 Synchronize minimizable pane button position with its state
- 438ddc0 Don't leave empty docking toolbars on the screen
- a80fcbf Remove closed panes from docking toolbars
- c2b8789 Show text only optionally for minimized panes
- ba0d5e7 Ensure that closed panes are not shown in docking toolbars later
- 2f6165f Show pane title as tooltip for its button when minimized
- 469b767 Allow minimized pane icon to be different from the normal one
File Changes
(12 files)
- M include/wx/aui/auibar.h (116)
- M include/wx/aui/dockart.h (9)
- M include/wx/aui/framemanager.h (63)
- M interface/wx/aui/auibar.h (173)
- M interface/wx/aui/framemanager.h (114)
- M samples/aui/auidemo.cpp (87)
- M samples/ribbon/ribbondemo.cpp (62)
- M samples/toolbar/toolbar.cpp (67)
- M src/aui/auibar.cpp (278)
- M src/aui/barartmsw.cpp (85)
- M src/aui/dockart.cpp (87)
- M src/aui/framemanager.cpp (463)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26009.patch
- https://github.com/wxWidgets/wxWidgets/pull/26009.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 3 commits.
- f1dc574 Add wxAUI_TB_ROTATE_ICON_WITH_TEXT style
- b571c19 Remove duplicated comment for wxAUI_ORIENTATION_MASK
- 1716477 Make minimized pane docking toolbars more configurable
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
AliKet
AliKet left a comment (wxWidgets/wxWidgets#26009)Thanks for implementing this.
I have no real comments, just an observation after testing this with wxGTK3 and wxQt:
If I resize a pane and then minimize it, it will reset to its default value after being restored. This behavior differs from that observed when it is maximized and then restored.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 4 commits.
- 4088d59 Remove unnecessary override of wxAuiMinDock::DoSetSize()
- 3f41426 Refactor: extract code in wxAuiManager::GetContainingDockSize()
- 2ee23a9 Remove unnecessary call to Show() when restoring minimized pane
- e3dbff6 Preserve size of the minimized panes
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26009)Thanks for noticing this, fixed now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26009)There has been no other comments, so I'm thinking about merging it and then improving it further in subsequent PRs later. I'll wait for a few more days just in case anybody notices something that really should not be merged in this one.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26009)Works ok in the aui sample on Windows.
Is there a way to get rid of the special toolbar once you have minimized a pane? I can make it go away when undocking both panes and then redocking them. But maybe it can be shown only if one ore more panes are minimized, and hiden once all are maximized?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26009)Is there a way to get rid of the special toolbar once you have minimized a pane?
This was one of the questions I asked in #23986. On one hand, this would make sense because currently we have a hysteresis effect: minimizing and restoring a pane bring the state to the original one, but the appearance is different, and I don't like this. OTOH it looks rather weird when restoring a single pane makes the dock containing multiple panes disappear. This wouldn't be a problem if we showed only minimized panes in the dock, but we want to (at least optionally) show all of then, so we can't avoid this.
I'm still not sure what is better/less worse here (I probably have a very slight preference towards removing the dock when there are no more minimized panes) and I don't think @craftyjon (who had originally requested this feature) has a definite opinion about this either.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26009)I don't think it makes sense to wait for much longer, so I'll merge this tomorrow if nobody objects.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Merged #26009 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.