Replace recently added wxFrame::Modality with wxWindowMode (PR #26188)
VZ
Don't make the modality enum wxFrame-specific as a very similar enum was also used with wxDialog.
Replace both of them with wxWindowMode defined in the common header.
Also use "Normal" instead of "None" to avoid conflict with a symbol defined in X11 headers.
See #26147.
Closes #26183.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26188
Commit Summary
- b3752e4 Replace recently added wxFrame::Modality with wxWindowMode
File Changes
(18 files)
- M include/wx/dialog.h (25)
- M include/wx/frame.h (11)
- M include/wx/osx/dialog.h (4)
- M include/wx/prntbase.h (10)
- M include/wx/qt/frame.h (2)
- M include/wx/toplevel.h (14)
- M interface/wx/frame.h (17)
- M interface/wx/print.h (8)
- M interface/wx/toplevel.h (12)
- M src/common/dlgcmn.cpp (14)
- M src/common/framecmn.cpp (29)
- M src/osx/carbon/statbrma.cpp (2)
- M src/osx/cocoa/dirdlg.mm (4)
- M src/osx/cocoa/filedlg.mm (4)
- M src/osx/cocoa/msgdlg.mm (4)
- M src/osx/dialog_osx.cpp (16)
- M src/osx/iphone/dialog.mm (2)
- M src/qt/frame.cpp (8)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26188.patch
- https://github.com/wxWidgets/wxWidgets/pull/26188.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26188)—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 1 commit.
- 34c2fd7 Replace recently added wxFrame::Modality with wxWindowMode
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
AliKet
AliKet left a comment (wxWidgets/wxWidgets#26188)Much better, thanks.for your time on this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26188)Cherry picked in the commit referenced above.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.