Fix accelerator characters shown in accessible label of controls (PR #26275)

16 views
Skip to first unread message

Quin Gillespie

unread,
Mar 6, 2026, 10:08:53 PM (8 days ago) Mar 6
to wx-...@googlegroups.com, Subscribed

The fix in 85c436d (Fix accessible label of checkboxes broken by
recent changes, 2026-03-06) made wxWindowAccessible::GetName() return
GetLabel() for all controls. However, GetLabel() returns the raw label
including '&' accelerator markers (e.g. "&Minimize to system tray"),
causing screen readers to announce the literal ampersand.

Fix this by passing the label through wxControl::GetLabelText(), which
strips accelerator markers, guarded by wxUSE_CONTROLS for configurations
that don't include controls.

See #26270.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/26275

Commit Summary

  • 5cfd7a1 Fix accelerator characters shown in accessible label of controls

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26275@github.com>

VZ

unread,
Mar 7, 2026, 8:43:46 AM (7 days ago) Mar 7
to wx-...@googlegroups.com, Push

@vadz pushed 1 commit.

  • 83ecf16 Use wxStripMenuCodes() to fix wxUniv build


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26275/before/5cfd7a142fc353b3e39b2dc0cc25ba87c95d63c2/after/83ecf16aa7a69d27ea1623b750cecefc954fef11@github.com>

Quin Gillespie

unread,
Mar 7, 2026, 10:12:53 AM (7 days ago) Mar 7
to wx-...@googlegroups.com, Subscribed
trypsynth left a comment (wxWidgets/wxWidgets#26275)

Ah, that's much smarter, thanks @vadz


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26275/c4016677445@github.com>

VZ

unread,
Mar 7, 2026, 10:54:23 AM (7 days ago) Mar 7
to wx-...@googlegroups.com, Subscribed

Closed #26275 via dec96a4.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/26275/issue_event/23359571916@github.com>

Reply all
Reply to author
Forward
0 new messages