CMake: Improve creating wayland protocol files (PR #25945)

12 views
Skip to first unread message

Maarten

unread,
Nov 1, 2025, 12:47:07 PM (8 days ago) Nov 1
to wx-...@googlegroups.com, Subscribed

Create the files in a temporary directory and only copy them to the final directory if the files are different.
This prevents the source files from being rebuilt every time cmake is run and the protocol files are replaced.

Exclude the protocols folder from being installed.

The entire setup header directory is installed, so exclude protocols.
see e.g. this build, and copied below for reference:

-- Installing: /usr/local/lib/wx/include/gtk3-unicode-3.3
-- Installing: /usr/local/lib/wx/include/gtk3-unicode-3.3/wx
-- Installing: /usr/local/lib/wx/include/gtk3-unicode-3.3/wx/setup.h
-- Installing: /usr/local/lib/wx/include/gtk3-unicode-3.3/wx/protocols
-- Installing: /usr/local/lib/wx/include/gtk3-unicode-3.3/wx/protocols/pointer-warp-v1-client-protocol.h
-- Installing: /usr/local/lib/wx/include/gtk3-unicode-3.3/wx/protocols/pointer-warp-v1-client-protocol.c

You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/25945

Commit Summary

  • 0d2bb06 CMake: Improve creating wayland protocol files

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25945@github.com>

VZ

unread,
Nov 1, 2025, 12:50:23 PM (8 days ago) Nov 1
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#25945)

Thanks, I didn't think about it, but it was obviously wrong to do what I did, so thank you for cleaning it up.

Will merge soon.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25945/c3476552668@github.com>

Maarten

unread,
Nov 1, 2025, 12:55:02 PM (8 days ago) Nov 1
to wx-...@googlegroups.com, Subscribed
MaartenBent left a comment (wxWidgets/wxWidgets#25945)

I actually asked about installing them in #25769 (comment), but assumed as well they wouldn't be installed automatically.

Seems I copy-pasted wrong, let me fix it...


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25945/c3476555289@github.com>

Maarten

unread,
Nov 1, 2025, 12:57:32 PM (8 days ago) Nov 1
to wx-...@googlegroups.com, Push

@MaartenBent pushed 1 commit.

  • 5927a9b CMake: Improve creating wayland protocol files


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25945/before/0d2bb06fb565593da2356310011f2a5d8b770f6a/after/5927a9b84f3c9795c535dffe720ae08e3394ae23@github.com>

VZ

unread,
Nov 1, 2025, 7:05:48 PM (8 days ago) Nov 1
to wx-...@googlegroups.com, Subscribed

Closed #25945 via 514486b.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25945/issue_event/20655042827@github.com>

Reply all
Reply to author
Forward
0 new messages