OSX guard toolbar toggle button when no bitmap (PR #26768)
Stefan Csomor
see bug #26763 and related fix PR by its author
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26768
Commit Summary
- 6a49b0c fixing crash when toggling a toolbar button with no bitmap
File Changes
(1 file)
- M src/osx/cocoa/toolbar.mm (2)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26768.patch
- https://github.com/wxWidgets/wxWidgets/pull/26768.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26768)@vadz I don't know how to change the author of this PR, so that the original author @alilie is correctly attributed, can you do it with the merge commit ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26768)Sure, I've cherry picked authorship information from the commit in the original PR. Will push soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26768)Forgot to ask: is this needed in 3.2 too?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#26768)Forgot to ask: is this needed in 3.2 too?
@vadz sorry, yes, it should be backported
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.