Improve sizer-creating code in the widgets sample (PR #26941)
PB
Fix the invalid sizer flag combination on the hyperlink page.
Replace pattern "wxSizer::Add(0, 0, wxSizerFlags(1).Centre());" with more readable "wxSizer::AddStretchSpacer(1)".
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26941
Commit Summary
- 02a9666 Improve sizer-creating code in the widgets sample
File Changes
(4 files)
- M samples/widgets/checkbox.cpp (8)
- M samples/widgets/datepick.cpp (8)
- M samples/widgets/hyperlnk.cpp (12)
- M samples/widgets/timepick.cpp (8)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26941.patch
- https://github.com/wxWidgets/wxWidgets/pull/26941.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
PB
PBfordev left a comment (wxWidgets/wxWidgets#26941)I think we should also:
1 Remove the 0 from all those wxSizerFlags(0).
2. Add FromDIP() wherever it is missing in all the SetMinSize() calls.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
Sorry for nitpicking but why do we need 1 inside AddStretchSpacer() calls? I'd just write it without arguments, why not?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
PB
@PBfordev pushed 1 commit.
- 0a791a0 Improve sizing-related code in the widgets sample
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
PB
PBfordev left a comment (wxWidgets/wxWidgets#26941)Sorry for nitpicking but why do we need
1insideAddStretchSpacer()calls?
Sorry, my bad.
I have also removed wxSizer::Add(n, n, ...) with wxSizer::AddSpacer(n) and added FromDIP() to all sizing calls where it was still missing (i.e., the most). I only skipped it in two places, where it is used for bitmaps (wxBitmapBundle and wxImageList): It should probably be used there as well, but I was not sure.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.