Fix missing accessible name for bitmap-only buttons under MSW (PR #27051)
Quin Gillespie
Buttons that show only a bitmap have no label, so screen readers only announce them as "button". This affects, for example, the buttons of wxEditableListBox and the close button of the generic wxInfoBar.
When a button has no label but has a tooltip, its tooltip is now used as its accessible name. Buttons with a label are not changed.
Tested with NVDA on Windows 11: the wxEditableListBox buttons are now read as "New item", "Edit item" and so on, and the wxInfoBar close button as "Hide this notification message."
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27051
Commit Summary
- 548d17a fix missing accessible name for bitmap-only buttons under MSW
File Changes
(2 files)
- M include/wx/msw/anybutton.h (4)
- M src/msw/anybutton.cpp (41)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27051.patch
- https://github.com/wxWidgets/wxWidgets/pull/27051.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz approved this pull request.
Thanks, this is definitely better than nothing! I'll merge this soon.
We could consider adding some SetAccessibleDescription(), but none of the existing code would be using it anyhow, of course... Still might be a good idea for the future?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Quin Gillespie
trypsynth left a comment (wxWidgets/wxWidgets#27051)Thanks!
Yes, I think this would be useful, and I'd start with SetAccessibleName() rather than the description: the name is what screen readers announce first, and it's what bitmap-only buttons and custom controls are missing most often. SetAccessibleDescription() could be added together with it for extra information, similar to what tooltips provide now.
And some existing code could use it: wxEditableListBox and wxInfoBar could give their buttons proper names instead of relying on the tooltip fallback from this PR.
Under MSW it could be implemented in wxWindowAccessible, and GTK and macOS have native equivalents too. I can test it under MSW and macOS, but not Linux. I'd be happy to do this in a separate PR if it sounds good to you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.