Fix for missing X11 libraries when linking wxGTK2 statically (PR #22813)
VZ
We must always use them with wxGTK2, so don't check wxHAVE_GDK_X11 for
it, otherwise we're never going to include X11 libraries when using it,
but they are always required.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/22813
Commit Summary
- 6f877e5 Fix for missing X11 libraries when linking wxGTK2 statically
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/22813.patch
- https://github.com/wxWidgets/wxWidgets/pull/22813.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@MaartenBent I'm reasonable sure that this is the right thing to do, but I'd still appreciate your confirmation, of course.
FWIW I also thought of always setting wxHAVE_GDK_X11 for GTK2, but this didn't seem right to me, and it's only used here, so I preferred to make this fix instead.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
Looks fine to me. Maybe it can even be simplified to (WXX11 OR WXMOTIF OR WXGTK2 OR wxHAVE_GDK_X11).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Thanks, but I think I prefer to keep WXGTK check as the condition reads more clearly with it, even if it's equivalent. I'll merge this soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #22813.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.