Support pen and brush styles in wxSVGGraphicsContext (PR #26586)
Maarten
Enable saving as SVG in the drawing sample using graphics context, and enable saving the graphics page as SVG.
Add missing pen and brush styles that wxSVGFileDC does support but wxSVGGraphicsContext did not.
Prevent SVG patterns with the same ID from being added multiple times, which would not pass SVG validation.
Fix wxOverlayDC in the drawing sample when wxGraphicsContext is disabled.
@Blake-Madden If possible, please check I didn't break anything. Thanks!
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26586
Commit Summary
- 8d7c1c6 Fix setting overlay opacity when wxGC is disabled
- 8746823 Fix overlay in drawing sample when wxGC is disabled
- 89d1921 Enable saving SVG for graphics context page in drawing sample
- 8bf3e15 Support pen and brush styles in wxSVGGraphicsContext
File Changes
(5 files)
- M include/wx/private/svg.h (8)
- M samples/drawing/drawing.cpp (30)
- M src/common/dcsvg.cpp (25)
- M src/common/svggc.cpp (36)
- M src/msw/overlay.cpp (2)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26586.patch
- https://github.com/wxWidgets/wxWidgets/pull/26586.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz approved this pull request.
This looks good to me, FWIW, thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.