#19201: On Windows, wxRearrangeCtrl needs mnemonics escaped from its items array strings.

13 views
Skip to first unread message

wxTrac

unread,
Jun 16, 2021, 10:28:15 AM6/16/21
to wx-...@googlegroups.com
#19201: On Windows, wxRearrangeCtrl needs mnemonics escaped from its items array
strings.
--------------------+--------------------
Reporter: OibafA | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: wxMSW | Version: 3.0.5
Keywords: | Blocked By:
Blocking: | Patch: 0
--------------------+--------------------
On Windows, if any of the items in the strings array that is provided to
wxRearrangeCtrl contains an ampersand ('&'), unless it's escaped it's not
going to be displayed.

On Linux, it is displayed just as expected.

Attached, there's a patch to minimal.cpp that shows the issue.

--
Ticket URL: <https://trac.wxwidgets.org/ticket/19201>

wxTrac

unread,
Jun 16, 2021, 10:28:54 AM6/16/21
to wx-...@googlegroups.com
#19201: On Windows, wxRearrangeCtrl needs mnemonics escaped from its items array
strings.
---------------------+-------------------
Reporter: OibafA | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: wxMSW | Version: 3.0.5
Resolution: | Keywords:
Blocked By: | Blocking:
Patch: 0 |
---------------------+-------------------
Changes (by OibafA):

* Attachment "patch" added.

wxTrac

unread,
Jun 16, 2021, 2:14:54 PM6/16/21
to wx-...@googlegroups.com
#19201: On Windows, wxRearrangeCtrl needs mnemonics escaped from its items array
strings.
---------------------+-----------------------
Reporter: OibafA | Owner:
Type: defect | Status: confirmed
Priority: normal | Milestone:
Component: wxMSW | Version: 3.0.5
Resolution: | Keywords:
Blocked By: | Blocking:
Patch: 0 |
---------------------+-----------------------
Changes (by vadz):

* status: new => confirmed


Comment:

The patch seems to be wrong, there is no mention of `wxRearrangeCtrl` in
it, but the bug can be reproduced simply enough in the unmodified dialogs
sample which shows this dialog.

Looking closer at it, it's actually not an issue with `wxRearrangeCtrl`
itself, but with wxMSW `wxCheckListBox`, so I've created
[https://github.com/wxWidgets/wxWidgets/pull/2399 this PR] fixing it
there, please let me know if you see any problems with it.

--
Ticket URL: <https://trac.wxwidgets.org/ticket/19201#comment:1>

wxTrac

unread,
Jun 24, 2021, 9:55:59 AM6/24/21
to wx-...@googlegroups.com
#19201: On Windows, wxRearrangeCtrl needs mnemonics escaped from its items array
strings.
---------------------+-------------------------------------
Reporter: OibafA | Owner: Vadim Zeitlin <vadim@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: wxMSW | Version: 3.0.5
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Patch: 0 |
---------------------+-------------------------------------
Changes (by Vadim Zeitlin <vadim@…>):

* owner: => Vadim Zeitlin <vadim@…>
* status: confirmed => closed
* resolution: => fixed


Comment:

In [changeset:"2d9c9d9689aa431a7c1072c1758670fea9d0a9a8/git-wxWidgets"
2d9c9d968/git-wxWidgets]:
{{{
#!CommitTicketReference repository="git-wxWidgets"
revision="2d9c9d9689aa431a7c1072c1758670fea9d0a9a8"
Fix handling of ampersands in wxCheckListBox under MSW

They were incorrectly interpreted as mnemonics when drawing
wxCheckListBox items, which didn't make sense and was inconsistent with
the other ports and even wxListBox in wxMSW itself.

It also affected wxRearrangeCtrl under MSW, which uses wxCheckListBox
for its implementation.

Closes #19201.
}}}

--
Ticket URL: <https://trac.wxwidgets.org/ticket/19201#comment:2>
Reply all
Reply to author
Forward
0 new messages