#13005: wxDataViewControl column sort event

8 views
Skip to first unread message

wxTrac

unread,
Mar 2, 2011, 9:40:45 AM3/2/11
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/13005>

#13005: wxDataViewControl column sort event
--------------------------------------------------------------------------------+
Reporter: Trigve | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: GUI-generic | Version: 2.9-svn
Keywords: wxDataViewControl column sort wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED | Blockedby:
Patch: 1 | Blocking:
--------------------------------------------------------------------------------+
Attached patch add support for wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED event
in generic implementation. I don't know if it should be done like this,
but for me it works. The second thing is if the event is sent in right
place, i.e. if column should already be in "sorted" state or not when
event is sent.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/13005>

wxTrac

unread,
Mar 3, 2011, 6:00:14 AM3/3/11
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:1>

#13005: Generate wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED in generifc wxDataViewControl
--------------------------------------------------------------------------------+
Reporter: Trigve | Owner:
Type: enhancement | Status: confirmed


Priority: normal | Milestone:
Component: GUI-generic | Version: 2.9-svn
Keywords: wxDataViewControl column sort wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED | Blockedby:
Patch: 1 | Blocking:
--------------------------------------------------------------------------------+

Changes (by vadz):

* cc: robert@… (added)
* status: new => confirmed


Comment:

I don't actually know when is `wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED`
supposed to be sent exactly: before sorting? After sorting? Should its
handler implement sorting? Robert, could you please explain what was the
original intention and/or when does GTK code generate it?

P.S. In any case check for `IsSortable()` is unnecessary, we never execute
this code for non-sortable columns.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:1>

wxTrac

unread,
Apr 5, 2011, 3:26:36 AM4/5/11
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:2>

#13005: Generate wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED in generifc wxDataViewControl

--------------------------------------------------------------------------------+
Reporter: Trigve | Owner:
Type: enhancement | Status: confirmed


Priority: normal | Milestone:
Component: GUI-generic | Version: 2.9-svn
Keywords: wxDataViewControl column sort wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED | Blockedby:
Patch: 1 | Blocking:
--------------------------------------------------------------------------------+

Comment(by Trigve):

Any news here?


--
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:2>

wxTrac

unread,
Apr 5, 2011, 6:15:56 PM4/5/11
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:3>

#13005: Generate wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED in generifc wxDataViewControl

--------------------------------------------------------------------------------+
Reporter: Trigve | Owner:
Type: enhancement | Status: confirmed


Priority: normal | Milestone:
Component: GUI-generic | Version: 2.9-svn
Keywords: wxDataViewControl column sort wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED | Blockedby:
Patch: 1 | Blocking:
--------------------------------------------------------------------------------+

Comment(by vadz):

I still don't know the semantics of this event so I can't judge whether
the patch is correct before learning about it. I hope Robert might have a
look at this before I have time to do it because it won't happen very soon
unfortunately.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:3>

wxTrac

unread,
Jul 21, 2011, 9:50:19 AM7/21/11
to wx-...@googlegroups.com
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:4>

#13005: Generate wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED in generifc wxDataViewControl

--------------------------+-------------------------------------------------
Reporter: Trigve | Owner:
Type: enhancement | Status: closed

Priority: normal | Milestone:
Component: GUI-generic | Version: 2.9-svn

Resolution: fixed | Keywords: wxDataViewControl column sort wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED
Blockedby: | Patch: 1
Blocking: |
--------------------------+-------------------------------------------------
Changes (by VZ):

* status: confirmed => closed
* resolution: => fixed


Comment:

(In [68322]) Send wxEVT_COMMAND_DATAVIEW_COLUMN_SORTED for generic version
too.

Send this event when the column used for sorting changed in the generic
implementation of wxDataViewCtrl too.

Closes #13005.


--
Ticket URL: <http://trac.wxwidgets.org/ticket/13005#comment:4>

Reply all
Reply to author
Forward
0 new messages