Some improvements to holiday authority code (PR #25788)

16 views
Skip to first unread message

Lauri Nurmi

unread,
Sep 10, 2025, 8:04:27 AM (4 days ago) Sep 10
to wx-...@googlegroups.com, Subscribed

Such as:

  • Move implementations to .cpp
  • Check valid date range for overridden implementations too

If something doesn't look like necessary, feel free to cherry-pick only the useful ones.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/25788

Commit Summary

  • 68b27a4 Do not duplicate DoGetHolidaysInRange() in the derived class
  • 83d7799 Move holiday implementations away from the header
  • 907b3fe Move range check to the public GetHolidaysInRange()
  • 62f7e66 Assert that DoGetHolidaysInRange and DoIsHoliday agree on holidays

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25788@github.com>

VZ

unread,
Sep 13, 2025, 8:56:22 AM (yesterday) Sep 13
to wx-...@googlegroups.com, Subscribed

Merged #25788 into master.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25788/issue_event/19677314997@github.com>

Reply all
Reply to author
Forward
0 new messages