Fix initial scale of wxGLCanvas under EGL/Wayland (PR #25994)

19 views
Skip to first unread message

VZ

unread,
Nov 26, 2025, 1:24:20 PM (7 days ago) Nov 26
to wx-...@googlegroups.com, Subscribed

This replaces #25991 with a much simpler and better fix.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/25994

Commit Summary

  • b261545 Do not log bogus system error in wxRenameFile()
  • 1fafa50 Fix initial scale of wxGLCanvas under EGL/Wayland
  • fb8d727 Make wxGLCanvasEGL friend function a normal member one

File Changes

(3 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25994@github.com>

VZ

unread,
Nov 26, 2025, 1:24:44 PM (7 days ago) Nov 26
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#25994)

Oops, the first commit doesn't belong to this PR, sorry, but I'm leaving it here.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25994/c3582682014@github.com>

paulcor

unread,
Nov 26, 2025, 2:25:09 PM (7 days ago) Nov 26
to wx-...@googlegroups.com, Subscribed

@paulcor commented on this pull request.


In src/unix/glegl.cpp:

>  
-    wxEGLUpdatePosition(win);
-    wxEGLSetScale(win, scale);
+static gboolean

Notify handler is void return type.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25994/review/3512468336@github.com>

VZ

unread,
Nov 26, 2025, 2:34:35 PM (7 days ago) Nov 26
to wx-...@googlegroups.com, Push

@vadz pushed 2 commits.

  • 0360870 Fix initial scale of wxGLCanvas under EGL/Wayland
  • c3d9bd9 Make wxGLCanvasEGL friend function a normal member one


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25994/before/fb8d72725508a9b4694f1f203e606cefe71d6147/after/c3d9bd95a78adc28e2279156c8fe0636fcecaad5@github.com>

VZ

unread,
Nov 26, 2025, 2:34:44 PM (7 days ago) Nov 26
to wx-...@googlegroups.com, Subscribed

@vadz commented on this pull request.


In src/unix/glegl.cpp:

>  
-    wxEGLUpdatePosition(win);
-    wxEGLSetScale(win, scale);
+static gboolean

Fixed, thanks.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25994/review/3512505396@github.com>

VZ

unread,
Nov 28, 2025, 11:04:46 AM (5 days ago) Nov 28
to wx-...@googlegroups.com, Subscribed

Merged #25994 into master.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25994/issue_event/21245156537@github.com>

Reply all
Reply to author
Forward
0 new messages