Parent wxDebugReportDialog's controls to their static boxes (PR #26918)
Gunter Königsman
When porting wxWidgets to GTK4 Claude reckons to have found 6 bugs in wxWidgets that hinder samples, example applications or tests from working. To me as a casual outsider the patches look like actually resolving existing bugs. I currently push them as separate pull requests so they can be individually reviewed.
The contents of the two wxStaticBoxSizers in the debug report dialog were created as children of the dialog rather than of the wxStaticBox.
That is the older convention, still supported, but wxStaticBoxSizer::CheckIfNonBoxChild() warns about it in a debug build, so simply raising a debug report produces warnings -- on every platform.
Create the buttons, the list of files, the notes field and the two explanatory texts with the box as their parent. The texts need CreateTextSizer() to be given a wxTextSizerWrapper for the box, since they are wrapped relative to their parent.
(cherry picked from commit 1536ea7)
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26918
Commit Summary
- 063ff2f Parent wxDebugReportDialog's controls to their static boxes
File Changes
(1 file)
- M src/generic/dbgrptg.cpp (30)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26918.patch
- https://github.com/wxWidgets/wxWidgets/pull/26918.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26918)And this looks good too, thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26918)P.S. Please keep authorship of your commits (you're still responsible for them) and add Assisted-by: trailer when they were done by a LLM.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.